Repository navigation
Conversation
Pending notes sit under '## Unreleased'; released sections are headed '## AtmosphericModels vX.Y.Z YYYY-MM-DD' without the dash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1-Bort-1
left a comment
There was a problem hiding this comment.
Independent review (advisory)
Verdict: APPROVE · 0 inline, 0 off the diff
Good
- The diff matches the PR card: 6 header lines change in CHANGELOG.md, and the note text, the
###groups and all other files are untouched (read in the diff). - Every
##line in CHANGELOG.md is now## Unreleasedor## AtmosphericModels vX.Y.Z YYYY-MM-DD; a grep of the##lines on this branch shows no exceptions. - v0.3.8–v0.3.12 now use the same header form as v0.3.0–v0.3.7, which were already in the convention, so the whole file is consistent.
- The in-repo
bin/releasestill works on this file: its awk matches^## AtmosphericModelsand reads the version from$3, both unaffected by dropping the-, and it skips## Unreleased(read bin/release:53-70). - Only headers changed, so the version, manifests and REUSE headers are untouched and no tests or docs are affected.
Not good
- Until the bump PR lands, the in-repo
bin/releaseonmainpasses over## Unreleasedand picks v0.3.12, which already matches Project.toml. A manual run would post the 0.3.12 notes again instead of failing. The oldv0.3.13 (unreleased)header failed the version check and blocked this, so the safety net is gone until the bump replaces the script. - CLAUDE.md says
bin/release"extracts the top section of CHANGELOG.md". With## Unreleasedon top, that section is no longer what it extracts. The doc is slightly stale, though CLAUDE.md is reasonably left out of a headers-only PR. - The card's second verification line quotes the box's error with a double space (
CHANGELOG top is (expected v0.3.12)). That is the tool's real output, but it reads like a typo to someone who hasn't seen the tool.
claude, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.
|
Local full suite: PASS (1 min, Julia 1.13.0, one cell of the matrix) |
|
|
From Per 1-Bart-1/Agents#635: since 1-Bart-1/Agents#634 the release bump writes headers as |
Every '## AtmosphericModels vX.Y.Z' header now carries its date as DD-MM-YYYY, the form the release bump writes since 1-Bart-1/Agents#634. CITATION.cff keeps its ISO date-released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## Unreleased and drop the dash from release headers in CHANGELOG.md## Unreleased and date release headers DD-MM-YYYY in CHANGELOG.md
|
From Per 1-Bart-1/Agents#635 (comment 6099024080) ISO is the convention after all: the bump goes back to writing |
Undoes 5311e03: the release bump writes ## <Package> vX.Y.Z YYYY-MM-DD (1-Bart-1/Agents#635), so every release header goes back to ISO. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## Unreleased and date release headers DD-MM-YYYY in CHANGELOG.md## Unreleased and drop the dash from CHANGELOG.md release headers
|
Fixed in 3fc1493: every release header is ISO YYYY-MM-DD again; CITATION.cff untouched. |
We want one changelog format across the OpenSourceAWE packages, so this gives AtmosphericModels the same headers as the others. Notes not yet released now sit under a plain
## Unreleasedheader, not under a version marked "(unreleased)". Every release is headed## AtmosphericModels vX.Y.Z YYYY-MM-DD, with no dash between the version and the date. Only header lines change. Every note reads as before, and the citation file is untouched.The release script in this repo is unchanged. The next version bump replaces it with the shared copy, which reads this format.
Verification
--dry-runon a simulated bump of this head (## Unreleased→## AtmosphericModels v0.3.13 2026-10-10, version 0.3.13): readsv0.3.13and the### Addednotes, exit 0 (GitHub calls stubbed)##header in CHANGELOG.md is## Unreleasedor## AtmosphericModels vX.Y.Z YYYY-MM-DDreusenot installed on the box)Opened by
1-Bort-1, an AI agent working for @1-Bart-1.Closes #54 · task
AtmosphericModels.jl-54